Skip to content

Allow updating daapLineageStatus on DataProducts #5498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2025
Merged

Allow updating daapLineageStatus on DataProducts #5498

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...apache/atlas/repository/store/graph/v2/preprocessor/datamesh/DataProductPreProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,14 +119,14 @@ private void processUpdateProduct(AtlasEntity entity, AtlasVertex vertex) throws
String state = vertex.getProperty(STATE_PROPERTY_KEY, String.class);

if (DELETED.name().equals(state)) {
// To allow product restoration but block all other updates if the product is archived
// To allow product restoration and update on daapLineageStatus but block all other updates if the product is archived
boolean isBeingRestored = false;

if (context != null && context.getEntitiesToRestore() != null) {
isBeingRestored = context.getEntitiesToRestore().contains(vertex);
}

if (!isBeingRestored) {
if (!isBeingRestored && !entity.hasAttribute(DAAP_LINEAGE_STATUS_ATTR)) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Archived Product Update Bypass Vulnerability

The condition !entity.hasAttribute(DAAP_LINEAGE_STATUS_ATTR) in processUpdateProduct incorrectly allows any update to an archived DataProduct if DAAP_LINEAGE_STATUS_ATTR is present in the update request. This bypasses the intended archive protection, allowing modifications to other attributes beyond just the lineage status.

Fix in Cursor Fix in Web

throw new AtlasBaseException(OPERATION_NOT_SUPPORTED, "Cannot update DataProduct that is Archived!");
}
}
Expand Down
Loading