Skip to content

Conversation

HujinoKun
Copy link

Hello,

I propose a simple fix to the VolumeClaimTemplate because GitOps tools (argocd or fluxcd) are noticing permanent DRIFTS causing unnecessary synchronizations and calls.

I therefore propose a PR to correct the problem by applying the default Kubernetes variables.

image

Provide description for the PR

Checklist

  • I have added unit tests
  • I have applied the change to all applicable products
  • The E2E test has passed (use e2e label)

Copy link

Thank you for your submission! Like many open source projects, we ask that you sign our CLA (Contributor License Agreement) before we can accept your contribution.
If your email is listed below, please ensure that you sign the CLA with the same email address.

The following users still need to sign our CLA:
❌HujinoKun

Already signed the CLA? To re-check, try refreshing the page.

@decompil3d
Copy link

@atlassian-cla-bot check

@decompil3d
Copy link

Apologies for the CLA issue. You have indeed signed the CLA and the check here is now green. The project team here can review and merge your request when they're ready.

@HujinoKun
Copy link
Author

Hello,

Would it be possible to get some feedback on my PR, please? :)

@HujinoKun
Copy link
Author

@decompil3d / @bianchi2 Can you check my PR please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants