Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was checking to update the predefined data that contains MT CKD 4.0 data. It turns out that they have changed their data format since my original code was written. In version 4.2 it seems. I therefore had to introduce another species tag for the new data format and update names accordingly. Hopefully, they will only change data in the future.
For @stefanbuehler , the new data format contains some sort of "closure" data. You might know more. I haven't activated that code by giving it a tag, but code to use it is being compiled. To test it, I think you can just exchange the data fields in the python object for the MTCKD430 object, because it is the same code.
There are overall quite large differences between this version and previous ones.