-
Notifications
You must be signed in to change notification settings - Fork 0
Use workers for file download #271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hagenw
wants to merge
41
commits into
main
Choose a base branch
from
workers-download
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 31 commits
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
6757d72
Add num_workers and chunk_size for downloads
hagenw 8e3eb10
Continue implementation
hagenw 972a423
Fix tests
hagenw d7aea51
Move arguments to classes
hagenw 4eaa0a3
Add benchmark script
hagenw 88dd39d
Revert "Move arguments to classes"
hagenw cae11bd
Add num_workers argument to interfaces
hagenw efd0a23
Fix test
hagenw bb972f5
Remove unused code
hagenw 4d0abdf
Try to fix pbar
hagenw 4a796f9
Update benchmark script
hagenw 886205d
Debug pbar
hagenw fd36881
Debug pbar
hagenw a3caa95
Improve progress bars
hagenw 24876ca
Add test for using num_workers
hagenw d8310f2
Fix linter
hagenw 515e9e0
Implement other solution for single worker
hagenw d36aea8
Try larger chunks
hagenw 7635588
Test very small chunk_size
hagenw 003a89c
DEBUG faster implementation
hagenw 02d2693
Fix writing in the same file
hagenw f18af4c
Clean up code
hagenw bb3968b
Depend on audeer>=2.3.1
hagenw acf4db5
Update benchmark script
hagenw f1f9319
Ensure interruption works for multi-threading
hagenw 6df134e
Ensure same error message for num_workers=1
hagenw 5f23b04
Fix linter
hagenw 7bc5c0c
Add tests for Crtl+C
hagenw b32d4b2
Fix coverage
hagenw 347eeb7
Move benchmark script
hagenw 8bf0e76
Add benchmark results
hagenw caa26b3
Ensure we do not have 0 chunk sizes
hagenw 3e7a09b
Ensure offset is always passed on
hagenw 0f21cec
Fix typo in README
hagenw 688f1fd
Setup pbar only once
hagenw db99d24
Revert "Setup pbar only once"
hagenw b4cbc11
Move to finally
hagenw 9d11bab
Try to fix
hagenw 2d7d692
Revert "Try to fix"
hagenw ca813d3
Revert "Move to finally"
hagenw c3c3088
Use single pbar
hagenw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.