Fixes Regex to stop '.A' class from being added in escapeValue()#40
Open
kruggeri wants to merge 2 commits intoautarc:masterfrom
Open
Fixes Regex to stop '.A' class from being added in escapeValue()#40kruggeri wants to merge 2 commits intoautarc:masterfrom
kruggeri wants to merge 2 commits intoautarc:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
When Optimal Select discovers a CSS attribute (i.e. class) with a line break in it, the regex replaces the line with an ".A" class name.
Our company stumbled on this instance when using a client's site which had the following odd class name:
Optimal Select's regex stripped the line break but returned a CSS Selector with
threeColumn.product.A.lastColumnI believe the function's original intention was to remove space until the beginning of the string, using the
\Aregex boundary. But, as we discovered, it returns a literal'.A'class.Why do we need this change?
To prevent incorrect CSS selectors.
Implementation Details
By using an empty string for the regex, we can select the correct element. The fix worked very well for us and we hope it could save others some trouble.