fixes issue #58: getSingleSelector throws error if the root is a shadow DOM root#59
Open
developerruhul wants to merge 1 commit intoautarc:masterfrom
Open
fixes issue #58: getSingleSelector throws error if the root is a shadow DOM root#59developerruhul wants to merge 1 commit intoautarc:masterfrom
getSingleSelector throws error if the root is a shadow DOM root#59developerruhul wants to merge 1 commit intoautarc:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modifies
checkTagfunction ofmatch.jswhich calls getElementsByTagName method againstelement.parentNodeeven if the element doesn't have the method. So when the parent is a shadowRoot that doesn't havegetElementsByTagNameit throws an error. So this PR modifies the function so that it calls querySelectorAll when getElementsByTagName isn't available.