Skip to content

validator: reject multi-sig JWS to ensure alg check matches verified signature #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MegaManSec wants to merge 1 commit into
base: master
Choose a base branch
from
Open

validator: reject multi-sig JWS to ensure alg check matches verified signature #343

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions validator/validator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,10 @@ func (v *Validator) ValidateToken(ctx context.Context, tokenString string) (inte
return nil, fmt.Errorf("could not parse the token: %w", err)
}

if len(token.Headers) != 1 {
return nil, fmt.Errorf("unsupported token: expected exactly one signature, got %d", len(token.Headers))
}

if err = validateSigningMethod(string(v.signatureAlgorithm), token.Headers[0].Algorithm); err != nil {
return nil, fmt.Errorf("signing method is invalid: %w", err)
}
Expand Down