fix: align response RequestID to standard x-request-id header #362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Verolop
changed the title
Completes alignment started in commit 34b8159. Response metadata now uses x-request-id for consistency with request-side header. Breaking change: code hardcoding "io.spicedb.respmeta.requestid" must use responsemeta.RequestID constant or update to "x-request-id".
…ility this adds x-request-id support in both headers and trailers: - RequestIDHeader: new header constant for HTTP/1.1 clients that can't easily read trailers through the gateway - RequestID: stays as a trailer to maintain gRPC retry policy compatibility (see cefe49ab for why trailers matter) - RequestIDLegacy: keeps the old io.spicedb.respmeta.requestid key around so existing clients don't break during transition
Verolop
force-pushed
the
fix/x-request-id
branch
from
202c652 to
b5ed306
Compare
miparnisari
approved these changes
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
this pr updates
responsemeta.RequestIDto use the same standard header name, eliminating the asymmetry between request and response metadata keys.This removes the need for custom header translation in HTTP gateways (like SpiceDB's).
References
Closes #361