test: retries on e2e matrix strategy and matrix generator jobs #3009
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iankhou
added
the
run-e2e
|
iankhou
force-pushed
the
iankhou-e2e-retries
branch
from
86bf877 to
d8fd44b
Compare
iankhou
commented
Sep 30, 2025
| - run: echo "$(npx tsx scripts/generate_sparse_test_matrix.ts 'packages/integration-tests/lib/test-e2e/deployment/*.deployment.test.js' '${{ needs.resolve_inputs.outputs.node }}' '${{ needs.resolve_inputs.outputs.os_for_e2e }}')" | ||
| - id: generateMatrix | ||
| run: echo "matrix=$(npx tsx scripts/generate_sparse_test_matrix.ts 'packages/integration-tests/lib/test-e2e/deployment/*.deployment.test.js' '${{ needs.resolve_inputs.outputs.node }}' '${{ needs.resolve_inputs.outputs.os_for_e2e }}')" >> "$GITHUB_OUTPUT" | ||
| - name: Generate matrix with retry |
There was a problem hiding this comment.
Takes 36 seconds on success.
iankhou
commented
Sep 30, 2025
| id: generateMatrix | ||
| uses: nick-fields/retry@v3 | ||
| with: | ||
| timeout_minutes: 5 |
There was a problem hiding this comment.
Takes 27s on success.
mrgrain
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
E2E tests can fail for a variety of reasons, and matrices are especially vulnerable to intermittent failure, due to the aggregation of several parameterized runs.
Changes
Implement retries for steps for which we anticipate or commonly see failures.
Validation
Run checks that include E2E tests.
Checklist
run-e2elabel set.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.