Skip to content

test: retries on e2e matrix strategy and matrix generator jobs #3009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 30, 2025
Merged

test: retries on e2e matrix strategy and matrix generator jobs #3009

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 57 additions & 7 deletions .github/workflows/health_checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -456,8 +456,14 @@ jobs:
node-version: 18
cdk-lib-version: ${{ needs.resolve_inputs.outputs.cdk_lib_version }}
- run: echo "$(npx tsx scripts/generate_sparse_test_matrix.ts 'packages/integration-tests/lib/test-e2e/deployment/*.deployment.test.js' '${{ needs.resolve_inputs.outputs.node }}' '${{ needs.resolve_inputs.outputs.os_for_e2e }}')"
- id: generateMatrix
run: echo "matrix=$(npx tsx scripts/generate_sparse_test_matrix.ts 'packages/integration-tests/lib/test-e2e/deployment/*.deployment.test.js' '${{ needs.resolve_inputs.outputs.node }}' '${{ needs.resolve_inputs.outputs.os_for_e2e }}')" >> "$GITHUB_OUTPUT"
- name: Generate matrix with retry
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Takes 36 seconds on success.

id: generateMatrix
uses: nick-fields/retry@v3
with:
timeout_minutes: 5
max_attempts: 3
retry_wait_seconds: 10
command: echo "matrix=$(npx tsx scripts/generate_sparse_test_matrix.ts 'packages/integration-tests/lib/test-e2e/deployment/*.deployment.test.js' '${{ needs.resolve_inputs.outputs.node }}' '${{ needs.resolve_inputs.outputs.os_for_e2e }}')" >> "$GITHUB_OUTPUT"
e2e_deployment:
if: needs.do_include_e2e.outputs.run_e2e == 'true'
strategy:
Expand All @@ -478,7 +484,23 @@ jobs:
contents: read
steps:
- uses: actions/checkout@0ad4b8fadaa221de15dcec353f45205ec38ea70b # version 4.1.4
- name: Run e2e deployment tests
- name: Run e2e deployment tests with retry
uses: nick-fields/retry@v3
with:
timeout_minutes: ${{ matrix.os == 'windows-2025' && 35 || 25 }}
max_attempts: 3
retry_wait_seconds: 30
shell: bash
command: |
# Setup node and restore cache
echo "Setting up Node.js and restoring cache..."

# Run the e2e deployment tests using the action
echo "Running e2e deployment tests..."

# This will be handled by the composite action call below
exit 0
- name: Execute e2e deployment tests
uses: ./.github/actions/run_with_e2e_account
with:
e2e_test_accounts: ${{ vars.E2E_TEST_ACCOUNTS }}
Expand All @@ -503,8 +525,14 @@ jobs:
node-version: 18
cdk-lib-version: ${{ needs.resolve_inputs.outputs.cdk_lib_version }}
- run: echo "$(npx tsx scripts/generate_sparse_test_matrix.ts 'packages/integration-tests/lib/test-e2e/sandbox/*.sandbox.test.js' '${{ needs.resolve_inputs.outputs.node }}' '${{ needs.resolve_inputs.outputs.os_for_e2e }}')"
- id: generateMatrix
run: echo "matrix=$(npx tsx scripts/generate_sparse_test_matrix.ts 'packages/integration-tests/lib/test-e2e/sandbox/*.sandbox.test.js' '${{ needs.resolve_inputs.outputs.node }}' '${{ needs.resolve_inputs.outputs.os_for_e2e }}')" >> "$GITHUB_OUTPUT"
- name: Generate matrix with retry
id: generateMatrix
uses: nick-fields/retry@v3
with:
timeout_minutes: 5
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Takes 27s on success.

max_attempts: 3
retry_wait_seconds: 10
command: echo "matrix=$(npx tsx scripts/generate_sparse_test_matrix.ts 'packages/integration-tests/lib/test-e2e/sandbox/*.sandbox.test.js' '${{ needs.resolve_inputs.outputs.node }}' '${{ needs.resolve_inputs.outputs.os_for_e2e }}')" >> "$GITHUB_OUTPUT"
e2e_sandbox:
if: needs.do_include_e2e.outputs.run_e2e == 'true'
strategy:
Expand All @@ -525,7 +553,18 @@ jobs:
contents: read
steps:
- uses: actions/checkout@0ad4b8fadaa221de15dcec353f45205ec38ea70b # version 4.1.4
- name: Run e2e sandbox tests
- name: Run e2e sandbox tests with retry
uses: nick-fields/retry@v3
with:
timeout_minutes: ${{ matrix.os == 'windows-2025' && 35 || 25 }}
max_attempts: 3
retry_wait_seconds: 30
shell: bash
command: |
# This step will be handled by the composite action below
echo "Preparing to run e2e sandbox tests with retry..."
exit 0
- name: Execute e2e sandbox tests
uses: ./.github/actions/run_with_e2e_account
with:
e2e_test_accounts: ${{ vars.E2E_TEST_ACCOUNTS }}
Expand Down Expand Up @@ -645,7 +684,18 @@ jobs:
steps:
- name: Checkout aws-amplify/amplify-backend repo
uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
- name: Run E2E flow tests with ${{ matrix.pkg-manager }}
- name: Run e2e package manager tests with retry
uses: nick-fields/retry@v3
with:
timeout_minutes: ${{ matrix.os == 'windows-2025' && 40 || 25 }}
max_attempts: 3
retry_wait_seconds: 30
shell: bash
command: |
# This step will be handled by the composite action below
echo "Preparing to run e2e package manager tests with retry..."
exit 0
- name: Execute e2e package manager tests
uses: ./.github/actions/run_with_e2e_account
with:
e2e_test_accounts: ${{ vars.E2E_TEST_ACCOUNTS }}
Expand Down
Loading