fix: retries in health_checks are not effective #3011
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
E2E tests are flaky due to unreliable network. Some retries that are implemented are not effective.
Recent intermittent E2E test failures:
Changes
Removed ineffective retries. Added retry for E2E Notices tests that have recently failed on ephemeral reasons.
Did not implement for deployment and sandbox tests, which require additional refactoring to retry (because they are implemented as GitHub Actions themselves, not scripts that can be retried).
Validation
Workflows running on this PR, with label
run-e2e
.Checklist
run-e2e
label set.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.