Skip to content

fix: retries in health_checks are not effective #3011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix: retries in health_checks are not effective #3011

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 6 additions & 39 deletions .github/workflows/health_checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -489,22 +489,6 @@ jobs:
contents: read
steps:
- uses: actions/checkout@0ad4b8fadaa221de15dcec353f45205ec38ea70b # version 4.1.4
- name: Run e2e deployment tests with retry
uses: nick-fields/retry@v3
with:
timeout_minutes: ${{ matrix.os == 'windows-2025' && 35 || 25 }}
max_attempts: 3
retry_wait_seconds: 30
shell: bash
command: |
# Setup node and restore cache
echo "Setting up Node.js and restoring cache..."

# Run the e2e deployment tests using the action
echo "Running e2e deployment tests..."

# This will be handled by the composite action call below
exit 0
- name: Execute e2e deployment tests
uses: ./.github/actions/run_with_e2e_account
with:
Expand Down Expand Up @@ -558,17 +542,6 @@ jobs:
contents: read
steps:
- uses: actions/checkout@0ad4b8fadaa221de15dcec353f45205ec38ea70b # version 4.1.4
- name: Run e2e sandbox tests with retry
uses: nick-fields/retry@v3
with:
timeout_minutes: ${{ matrix.os == 'windows-2025' && 35 || 25 }}
max_attempts: 3
retry_wait_seconds: 30
shell: bash
command: |
# This step will be handled by the composite action below
echo "Preparing to run e2e sandbox tests with retry..."
exit 0
- name: Execute e2e sandbox tests
uses: ./.github/actions/run_with_e2e_account
with:
Expand Down Expand Up @@ -606,7 +579,12 @@ jobs:
cdk-lib-version: ${{ needs.resolve_inputs.outputs.cdk_lib_version }}
- run: cd packages/cli && npm link
- name: Run e2e notices tests
run: npm run test:dir packages/integration-tests/lib/test-e2e/notices.test.js
uses: nick-fields/retry@v3
with:
timeout_minutes: ${{ matrix.os == 'windows-2025' && 8 || 5 }}
max_attempts: 3
retry_wait_seconds: 30
command: npm run test:dir packages/integration-tests/lib/test-e2e/notices.test.js
e2e_backend_output:
if: needs.do_include_e2e.outputs.run_e2e == 'true'
runs-on: ubuntu-latest
Expand Down Expand Up @@ -689,17 +667,6 @@ jobs:
steps:
- name: Checkout aws-amplify/amplify-backend repo
uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
- name: Run e2e package manager tests with retry
uses: nick-fields/retry@v3
with:
timeout_minutes: ${{ matrix.os == 'windows-2025' && 40 || 25 }}
max_attempts: 3
retry_wait_seconds: 30
shell: bash
command: |
# This step will be handled by the composite action below
echo "Preparing to run e2e package manager tests with retry..."
exit 0
- name: Execute e2e package manager tests
uses: ./.github/actions/run_with_e2e_account
with:
Expand Down
Loading