feat: retry e2e tests at the action level #3012
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
mrgrain
reviewed
Oct 2, 2025
| shell: bash | ||
| command: | | ||
| # This step will be handled by the composite action below | ||
| echo "Preparing to run e2e package manager tests with retry..." |
There was a problem hiding this comment.
I think we might want to keep the logs
There was a problem hiding this comment.
Will do, I've put them back
mrgrain
requested changes
Oct 2, 2025
Comment on lines
500
to
507
| # Setup node and restore cache | ||
| echo "Setting up Node.js and restoring cache..." | ||
| # Run the e2e deployment tests using the action | ||
| echo "Running e2e deployment tests..." | ||
| # This will be handled by the composite action call below | ||
| exit 0 |
Comment on lines
-569
to
-571
| # This step will be handled by the composite action below | ||
| echo "Preparing to run e2e sandbox tests with retry..." | ||
| exit 0 |
mrgrain
approved these changes
Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
E2E tests are flaky due to unreliable network. Some retries that are implemented are not effective.
Recent intermittent E2E test failures:
Changes
Removed ineffective retries. Added retry for E2E Notices tests that have recently failed on ephemeral reasons.
Implemented retries for deployment and sandbox tests at the action level.
Validation
Workflows running on this PR, with label
run-e2e.Checklist
run-e2elabel set.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.