-
Notifications
You must be signed in to change notification settings - Fork 102
feat: retry e2e tests at the action level #3012
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -489,22 +489,6 @@ jobs: | |
contents: read | ||
steps: | ||
- uses: actions/checkout@0ad4b8fadaa221de15dcec353f45205ec38ea70b # version 4.1.4 | ||
- name: Run e2e deployment tests with retry | ||
uses: nick-fields/retry@v3 | ||
with: | ||
timeout_minutes: ${{ matrix.os == 'windows-2025' && 35 || 25 }} | ||
max_attempts: 3 | ||
retry_wait_seconds: 30 | ||
shell: bash | ||
command: | | ||
# Setup node and restore cache | ||
echo "Setting up Node.js and restoring cache..." | ||
|
||
# Run the e2e deployment tests using the action | ||
echo "Running e2e deployment tests..." | ||
|
||
# This will be handled by the composite action call below | ||
exit 0 | ||
- name: Execute e2e deployment tests | ||
uses: ./.github/actions/run_with_e2e_account | ||
with: | ||
|
@@ -558,17 +542,6 @@ jobs: | |
contents: read | ||
steps: | ||
- uses: actions/checkout@0ad4b8fadaa221de15dcec353f45205ec38ea70b # version 4.1.4 | ||
- name: Run e2e sandbox tests with retry | ||
uses: nick-fields/retry@v3 | ||
with: | ||
timeout_minutes: ${{ matrix.os == 'windows-2025' && 35 || 25 }} | ||
max_attempts: 3 | ||
retry_wait_seconds: 30 | ||
shell: bash | ||
command: | | ||
# This step will be handled by the composite action below | ||
echo "Preparing to run e2e sandbox tests with retry..." | ||
exit 0 | ||
Comment on lines
-569
to
-571
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. keep |
||
- name: Execute e2e sandbox tests | ||
uses: ./.github/actions/run_with_e2e_account | ||
with: | ||
|
@@ -606,7 +579,12 @@ jobs: | |
cdk-lib-version: ${{ needs.resolve_inputs.outputs.cdk_lib_version }} | ||
- run: cd packages/cli && npm link | ||
- name: Run e2e notices tests | ||
run: npm run test:dir packages/integration-tests/lib/test-e2e/notices.test.js | ||
uses: nick-fields/retry@v3 | ||
with: | ||
timeout_minutes: ${{ matrix.os == 'windows-2025' && 8 || 5 }} | ||
max_attempts: 3 | ||
retry_wait_seconds: 30 | ||
command: npm run test:dir packages/integration-tests/lib/test-e2e/notices.test.js | ||
e2e_backend_output: | ||
if: needs.do_include_e2e.outputs.run_e2e == 'true' | ||
runs-on: ubuntu-latest | ||
|
@@ -689,17 +667,6 @@ jobs: | |
steps: | ||
- name: Checkout aws-amplify/amplify-backend repo | ||
uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 | ||
- name: Run e2e package manager tests with retry | ||
uses: nick-fields/retry@v3 | ||
with: | ||
timeout_minutes: ${{ matrix.os == 'windows-2025' && 40 || 25 }} | ||
max_attempts: 3 | ||
retry_wait_seconds: 30 | ||
shell: bash | ||
command: | | ||
# This step will be handled by the composite action below | ||
echo "Preparing to run e2e package manager tests with retry..." | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we might want to keep the logs There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Will do, I've put them back |
||
exit 0 | ||
- name: Execute e2e package manager tests | ||
uses: ./.github/actions/run_with_e2e_account | ||
with: | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
keep