Skip to content

Improve type error regex #2022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Improve type error regex #2022

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/rich-jokes-divide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@aws-amplify/backend-deployer': patch
---

Improve type error regex
11 changes: 11 additions & 0 deletions packages/backend-deployer/src/cdk_error_mapper.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,17 @@ const testErrorMappings = [
EOL +
` at lookup(/some_random/path.js: 1: 3005)`,
},
{
errorMessage: `TypeError [ERR_INVALID_MODULE_SPECIFIER]: Invalid module ..../function/foo/resource.ts is not a valid package name imported from
/Users/foo/Desktop/amplify-app/amplify/storage/foo/resource.ts
at new NodeError (node:internal/errors:405:5)`,
expectedTopLevelErrorMessage:
'Unable to build the Amplify backend definition.',
errorName: 'SyntaxError',
expectedDownstreamErrorMessage: `TypeError [ERR_INVALID_MODULE_SPECIFIER]: Invalid module ..../function/foo/resource.ts is not a valid package name imported from
/Users/foo/Desktop/amplify-app/amplify/storage/foo/resource.ts
at new NodeError (node:internal/errors:405:5)`,
},
{
errorMessage: 'Has the environment been bootstrapped',
expectedTopLevelErrorMessage:
Expand Down
2 changes: 1 addition & 1 deletion packages/backend-deployer/src/cdk_error_mapper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ export class CdkErrorMapper {
},
{
errorRegex: new RegExp(
`(SyntaxError|ReferenceError|TypeError):((?:.|${this.multiLineEolRegex})*?at .*)`
`(SyntaxError|ReferenceError|TypeError)( \\[[A-Z_]+])?:((?:.|${this.multiLineEolRegex})*?at .*)`
Copy link
Contributor Author

@sobolk sobolk Sep 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you wonder why ] is not escaped. it doesn't have to be if there's no opening [.
image

),
humanReadableErrorMessage:
'Unable to build the Amplify backend definition.',
Expand Down