Notices manifest schema #2562
Notices manifest schema #2562
Conversation
| }), | ||
| z.object({ | ||
| type: z.literal('backendComponent'), | ||
| backendComponent: z.enum(['data', 'auth', 'function', 'storage']), |
|
|
||
| const noticePredicateSchema = z.discriminatedUnion('type', [ | ||
| z.object({ | ||
| type: z.literal('packageVersion'), |
There was a problem hiding this comment.
I don't think the node version will be captured by this, if not, we should add that as a predicate. What about OS as well?
| z.object({ | ||
| type: z.literal('frequency'), | ||
| frequency: z.enum(['command', 'deployment', 'once', 'daily']), | ||
| }), |
There was a problem hiding this comment.
Didn't we also want the expiration to be part of the notices?
There was a problem hiding this comment.
I was on the edge if we should add it now or just "unpublish" a notice.
I guess it won't hurt to include it.
| export type Notice = z.infer<typeof noticeSchema>; | ||
|
|
||
| export const noticesManifestSchema = z.object({ | ||
| currentNotices: z.array(noticeSchema), |
There was a problem hiding this comment.
why current not just notices?
| assert.ok( | ||
| !ids.has(notice.id), | ||
| `Notice ids must be unique. ${notice.id} is duplicated.` | ||
| ); |
There was a problem hiding this comment.
should we throw AmplifyFault instead?
| z.object({ | ||
| type: z.literal('packageVersion'), | ||
| packageName: z.string(), | ||
| versionRange: z.string(), |
There was a problem hiding this comment.
I have seen some cdk notices with an upper bound and lower bound for the range (EX: Affected versions: cli: >=2.0.0 <=2.1005.0) in these cases, would the version range look like this '>=2.0.0 <=2.1005.0'?
There was a problem hiding this comment.
Yes. Here's the spec https://docs.npmjs.com/cli/v6/using-npm/semver#ranges .
There was a problem hiding this comment.
or here as well https://www.npmjs.com/package/semver#ranges
🦋 Changeset detectedLatest commit: 2b9bf1b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
3 participants
Changes
This PR:
Validation
Added tests
Checklist
run-e2elabel set.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.