Skip to content

fix: check_api_changes often fails on network error #3010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 30, 2025
Merged

fix: check_api_changes often fails on network error #3010

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fea3158
fix: check_api_changes often fails on network error
iankhou Sep 30, 2025
59317de
Merge branch 'main' into iankhou-check-api-changes-retry
iankhou Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions .github/workflows/health_checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,10 +267,15 @@ jobs:
with:
path: base-branch-content
ref: ${{ github.event.pull_request.base.sha }}
- name: Check API changes
run: |
mkdir api-validation-projects
npx tsx scripts/check_api_changes.ts base-branch-content api-validation-projects
- name: Check API changes with retry
uses: nick-fields/retry@v3
with:
timeout_minutes: 20
max_attempts: 3
retry_wait_seconds: 30
command: |
mkdir -p api-validation-projects
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we possible perform retries, we need -p here, as the directory will already exist.

npx tsx scripts/check_api_changes.ts base-branch-content api-validation-projects
handle_dependabot_version_update:
if: github.event_name == 'pull_request' && github.event.pull_request.user.login == 'dependabot[bot]'
runs-on: ubuntu-latest
Expand Down
Loading