generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 101
feat: add timezone support to scheduling for Lambda functions #3016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
3c84b8a
feat: add timezone support to scheduling for Lambda functions
fossamagna c0e963a
Merge branch 'main' into schedule-timezone
iankhou ee33609
test: add validation for invalid schedule format in ScheduleParser
fossamagna 9396320
test: add tests for handling invalid timezones in schedule property
fossamagna 2debf5a
chore: bump '@aws-amplify/backend' version
fossamagna File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
--- | ||
'@aws-amplify/backend-function': minor | ||
'@aws-amplify/backend': minor | ||
--- | ||
|
||
feat: add timezone support to scheduling Lambda functions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -34,7 +34,10 @@ export type AddEnvironmentFactory = { | |
}; | ||
|
||
// @public (undocumented) | ||
export type CronSchedule = `${string} ${string} ${string} ${string} ${string}` | `${string} ${string} ${string} ${string} ${string} ${string}`; | ||
export type CronSchedule = CronScheduleExpression | ZonedCronSchedule; | ||
|
||
// @public (undocumented) | ||
export type CronScheduleExpression = `${string} ${string} ${string} ${string} ${string}` | `${string} ${string} ${string} ${string} ${string} ${string}`; | ||
|
||
// @public (undocumented) | ||
type DataClientConfig = { | ||
|
@@ -141,7 +144,22 @@ type ResourceConfig = { | |
}; | ||
|
||
// @public (undocumented) | ||
export type TimeInterval = `every ${number}m` | `every ${number}h` | `every day` | `every week` | `every month` | `every year`; | ||
export type TimeInterval = ZonedTimeInterval | TimeIntervalExpression; | ||
|
||
// @public (undocumented) | ||
export type TimeIntervalExpression = `every ${number}m` | `every ${number}h` | `every day` | `every week` | `every month` | `every year`; | ||
|
||
// @public (undocumented) | ||
export type ZonedCronSchedule = { | ||
cron: CronScheduleExpression; | ||
timezone: string; | ||
}; | ||
|
||
// @public (undocumented) | ||
export type ZonedTimeInterval = { | ||
rate: TimeIntervalExpression; | ||
timezone: string; | ||
Comment on lines
+155
to
+161
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same as comments above - TimeZone |
||
}; | ||
|
||
// (No @packageDocumentation comment for this package) | ||
|
||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -495,17 +495,54 @@ void describe('AmplifyFunctionFactory', () => { | |
}).getInstance(getInstanceProps); | ||
const template = Template.fromStack(lambda.stack); | ||
|
||
template.hasResourceProperties('AWS::Events::Rule', { | ||
template.hasResourceProperties('AWS::Scheduler::Schedule', { | ||
ScheduleExpression: 'cron(*/5 * * * ? *)', | ||
Targets: [ | ||
{ | ||
Arn: { | ||
// eslint-disable-next-line spellcheck/spell-checker | ||
'Fn::GetAtt': ['handlerlambdaE29D1580', 'Arn'], | ||
}, | ||
Id: 'Target0', | ||
ScheduleExpressionTimezone: 'UTC', | ||
Target: { | ||
Arn: { | ||
// eslint-disable-next-line spellcheck/spell-checker | ||
'Fn::GetAtt': ['handlerlambdaE29D1580', 'Arn'], | ||
}, | ||
], | ||
}, | ||
}); | ||
}); | ||
|
||
void it('sets valid schedule - rate with timezone', () => { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could you add some test cases for invalid inputs for rate and timezone (invalid timezone)? |
||
const lambda = defineFunction({ | ||
entry: './test-assets/default-lambda/handler.ts', | ||
schedule: { rate: 'every 5m', timezone: 'America/New_York' }, | ||
}).getInstance(getInstanceProps); | ||
const template = Template.fromStack(lambda.stack); | ||
|
||
template.hasResourceProperties('AWS::Scheduler::Schedule', { | ||
ScheduleExpression: 'cron(*/5 * * * ? *)', | ||
ScheduleExpressionTimezone: 'America/New_York', | ||
Target: { | ||
Arn: { | ||
// eslint-disable-next-line spellcheck/spell-checker | ||
'Fn::GetAtt': ['handlerlambdaE29D1580', 'Arn'], | ||
}, | ||
}, | ||
}); | ||
}); | ||
|
||
void it('sets schedule - rate with invalid timezone', () => { | ||
const lambda = defineFunction({ | ||
entry: './test-assets/default-lambda/handler.ts', | ||
schedule: { rate: 'every 5m', timezone: 'Invalid/Timezone' }, | ||
}).getInstance(getInstanceProps); | ||
const template = Template.fromStack(lambda.stack); | ||
|
||
// CDK does not validate timezone | ||
template.hasResourceProperties('AWS::Scheduler::Schedule', { | ||
ScheduleExpression: 'cron(*/5 * * * ? *)', | ||
ScheduleExpressionTimezone: 'Invalid/Timezone', | ||
Target: { | ||
Arn: { | ||
// eslint-disable-next-line spellcheck/spell-checker | ||
'Fn::GetAtt': ['handlerlambdaE29D1580', 'Arn'], | ||
}, | ||
}, | ||
}); | ||
}); | ||
|
||
|
@@ -516,17 +553,54 @@ void describe('AmplifyFunctionFactory', () => { | |
}).getInstance(getInstanceProps); | ||
const template = Template.fromStack(lambda.stack); | ||
|
||
template.hasResourceProperties('AWS::Events::Rule', { | ||
template.hasResourceProperties('AWS::Scheduler::Schedule', { | ||
ScheduleExpression: 'cron(0 1 * * ? *)', | ||
Targets: [ | ||
{ | ||
Arn: { | ||
// eslint-disable-next-line spellcheck/spell-checker | ||
'Fn::GetAtt': ['handlerlambdaE29D1580', 'Arn'], | ||
}, | ||
Id: 'Target0', | ||
ScheduleExpressionTimezone: 'UTC', | ||
Target: { | ||
Arn: { | ||
// eslint-disable-next-line spellcheck/spell-checker | ||
'Fn::GetAtt': ['handlerlambdaE29D1580', 'Arn'], | ||
}, | ||
], | ||
}, | ||
}); | ||
}); | ||
|
||
void it('sets valid schedule - cron with timezone', () => { | ||
const lambda = defineFunction({ | ||
entry: './test-assets/default-lambda/handler.ts', | ||
schedule: { cron: '0 1 * * ?', timezone: 'America/New_York' }, | ||
}).getInstance(getInstanceProps); | ||
const template = Template.fromStack(lambda.stack); | ||
|
||
template.hasResourceProperties('AWS::Scheduler::Schedule', { | ||
ScheduleExpression: 'cron(0 1 * * ? *)', | ||
ScheduleExpressionTimezone: 'America/New_York', | ||
Target: { | ||
Arn: { | ||
// eslint-disable-next-line spellcheck/spell-checker | ||
'Fn::GetAtt': ['handlerlambdaE29D1580', 'Arn'], | ||
}, | ||
}, | ||
}); | ||
}); | ||
|
||
void it('sets schedule - cron with invalid timezone', () => { | ||
const lambda = defineFunction({ | ||
entry: './test-assets/default-lambda/handler.ts', | ||
schedule: { cron: '0 1 * * ?', timezone: 'Invalid/Timezone' }, | ||
}).getInstance(getInstanceProps); | ||
const template = Template.fromStack(lambda.stack); | ||
|
||
// CDK does not validate timezone | ||
template.hasResourceProperties('AWS::Scheduler::Schedule', { | ||
ScheduleExpression: 'cron(0 1 * * ? *)', | ||
ScheduleExpressionTimezone: 'Invalid/Timezone', | ||
Target: { | ||
Arn: { | ||
// eslint-disable-next-line spellcheck/spell-checker | ||
'Fn::GetAtt': ['handlerlambdaE29D1580', 'Arn'], | ||
}, | ||
}, | ||
}); | ||
}); | ||
|
||
|
@@ -537,14 +611,16 @@ void describe('AmplifyFunctionFactory', () => { | |
}).getInstance(getInstanceProps); | ||
const template = Template.fromStack(lambda.stack); | ||
|
||
template.resourceCountIs('AWS::Events::Rule', 2); | ||
template.resourceCountIs('AWS::Scheduler::Schedule', 2); | ||
|
||
template.hasResourceProperties('AWS::Events::Rule', { | ||
template.hasResourceProperties('AWS::Scheduler::Schedule', { | ||
ScheduleExpression: 'cron(0 1 * * ? *)', | ||
ScheduleExpressionTimezone: 'UTC', | ||
}); | ||
|
||
template.hasResourceProperties('AWS::Events::Rule', { | ||
template.hasResourceProperties('AWS::Scheduler::Schedule', { | ||
ScheduleExpression: 'cron(*/5 * * * ? *)', | ||
ScheduleExpressionTimezone: 'UTC', | ||
}); | ||
}); | ||
|
||
|
@@ -554,7 +630,7 @@ void describe('AmplifyFunctionFactory', () => { | |
}).getInstance(getInstanceProps); | ||
const template = Template.fromStack(lambda.stack); | ||
|
||
template.resourceCountIs('AWS::Events::Rule', 0); | ||
template.resourceCountIs('AWS::Scheduler::Schedule', 0); | ||
}); | ||
}); | ||
|
||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to bump
@aws-amplify/backend
too.