Skip to content

Conversation

@vishalkatikineni
Copy link
Contributor

Add Types resources to keyspaces-controller

Issue #, if available: 2482

Description of changes:
Enable Types in keyspaces-controller

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Add udt resources to keyspaces-controller
@ack-prow ack-prow bot requested review from a-hilaly and rushmash91 May 14, 2025 22:09
@ack-prow
Copy link

ack-prow bot commented May 14, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vishalkatikineni
Once this PR has been reviewed and has the lgtm label, please assign a-hilaly for approval by writing /assign @a-hilaly in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 14, 2025
@ack-prow
Copy link

ack-prow bot commented May 14, 2025

Hi @vishalkatikineni. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@a-hilaly
Copy link
Member

a-hilaly commented Oct 6, 2025

/ok-to-test

@ack-prow ack-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 6, 2025
@ack-prow
Copy link

ack-prow bot commented Oct 30, 2025

@vishalkatikineni: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
keyspaces-verify-attribution ea88ddc link false /test keyspaces-verify-attribution
keyspaces-kind-e2e ea88ddc link true /test keyspaces-kind-e2e
keyspaces-unit-test ea88ddc link true /test keyspaces-unit-test
keyspaces-recommended-policy-test ea88ddc link true /test keyspaces-recommended-policy-test
keyspaces-metadata-file-test ea88ddc link true /test keyspaces-metadata-file-test
keyspaces-release-test ea88ddc link true /test keyspaces-release-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants