chore: Fix correlationid case insensitive #1049
Open
+214
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ies in order: Original path (case-sensitive) - tries the exact path you specified Output case transformation - applies the configured logger output case (for backward compatibility) Case-insensitive match - falls back to case-insensitive property matching
pull-request-size
bot
added
the
size/L
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #1049 +/- ##
===========================================
+ Coverage 78.17% 78.20% +0.02%
===========================================
Files 298 298
Lines 12012 12037 +25
Branches 1443 1449 +6
===========================================
+ Hits 9390 9413 +23
Misses 2160 2160
- Partials 462 464 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: closes #1048
Summary
Changes
This pull request introduces improved support for retrieving correlation IDs.
The changes focus on making the correlation ID extraction more robust, exposing it via new APIs
Correlation ID extraction improvements
CaptureCorrelationIdmethod inLoggingAspect.csto try multiple strategies for extracting the correlation ID: first by exact (case-sensitive) match, then by output case transformation, and finally by case-insensitive search. This makes correlation ID retrieval more reliable across various event shapes.Public API enhancements
CorrelationIdproperty to theLoggerclass, allowing easy access to the current correlation ID from log context.GetCorrelationIdextension method forILogger, providing a convenient way to access the correlation ID from any logger instance.User experience
Checklist
Please leave checklist items unchecked if they do not apply to your change.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.