Skip to content

fix: cold start only on on-demand invocation #2317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Attyuttam wants to merge 7 commits into from
+754 −710
Closed

fix: cold start only on on-demand invocation #2317

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5ec3c21
fix: cold start only on on-demand invocation
Attyuttam Nov 26, 2025
090de1d
fix: cold start only on on-demand invocation
Attyuttam Nov 26, 2025
5d5d43d
fix: cold start only on on-demand invocation
Attyuttam Nov 27, 2025
75d04c1
Merge branch 'main' into main
Attyuttam Nov 27, 2025
ff08406
mvn clean test is successful
Attyuttam Nov 28, 2025
35bfb4e
Merge branch 'main' of https://github.com/Attyuttam/powertools-lambda…
Attyuttam Nov 28, 2025
5b47395
reversed the sqllite changes
Attyuttam Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions pom.xml
View file
Open in desktop
Copy link
Contributor

@phipag phipag Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert all changes in this file. This is not needed in the parent pom. Please make sure to add it in the corresponding module poms such as all the logging modules.

Original file line number Diff line number Diff line change
Expand Up @@ -501,6 +501,11 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<configuration>
<environmentVariables>
<AWS_LAMBDA_INITIALIZATION_TYPE>on-demand</AWS_LAMBDA_INITIALIZATION_TYPE>
</environmentVariables>
</configuration>
</plugin>
<plugin>
<groupId>org.jacoco</groupId>
Expand Down Expand Up @@ -632,6 +637,9 @@
--add-opens java.base/java.util=ALL-UNNAMED
--add-opens java.base/java.lang=ALL-UNNAMED
</argLine>
<environmentVariables>
<AWS_LAMBDA_INITIALIZATION_TYPE>on-demand</AWS_LAMBDA_INITIALIZATION_TYPE>
</environmentVariables>
</configuration>
</plugin>
</plugins>
Expand Down
2 changes: 2 additions & 0 deletions ...mmon/src/main/java/software/amazon/lambda/powertools/common/internal/LambdaConstants.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,4 +28,6 @@ private LambdaConstants() {
public static final String ROOT_EQUALS = "Root=";
public static final String POWERTOOLS_SERVICE_NAME = "POWERTOOLS_SERVICE_NAME";
public static final String SERVICE_UNDEFINED = "service_undefined";
public static final String AWS_LAMBDA_INITIALIZATION_TYPE = "AWS_LAMBDA_INITIALIZATION_TYPE";
public static final String ON_DEMAND_INVOCATION_TYPE = "on-demand";
}
9 changes: 8 additions & 1 deletion ...c/main/java/software/amazon/lambda/powertools/common/internal/LambdaHandlerProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,12 +88,19 @@
}

// Method used for testing purposes
protected static void resetServiceName() {

Check failure on line 91 in powertools-common/src/main/java/software/amazon/lambda/powertools/common/internal/LambdaHandlerProcessor.java

View workflow job for this annotation

GitHub Actions / pmd_analyse

Avoid protected methods in a final class that doesnt extend anything other than Object. Change to private or package access. 

Do not use protected methods in most final classes since they cannot be subclassed. This should
only be allowed in final classes that extend other classes with protected methods (whose
visibility cannot be reduced). Clarify your intent by using private or package access modifiers instead.

AvoidProtectedMethodInFinalClassNotExtending (Priority: 1, Ruleset: Code Style)
https://docs.pmd-code.org/snapshot/pmd_rules_java_codestyle.html#avoidprotectedmethodinfinalclassnotextending
serviceName = calculateServiceName();
}

public static boolean isColdStart() {
return isColdStart == null;
if (isColdStart != null) {
return isColdStart;
}

String initType = System.getenv(LambdaConstants.AWS_LAMBDA_INITIALIZATION_TYPE);
isColdStart = LambdaConstants.ON_DEMAND_INVOCATION_TYPE.equals(initType);

return isColdStart;
}

public static void coldStartDone() {
Expand Down
1 change: 1 addition & 0 deletions ...st/java/software/amazon/lambda/powertools/common/internal/LambdaHandlerProcessorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,7 @@ void extractContext_notKnownHandler() {
}

@Test
@SetEnvironmentVariable(key = LambdaConstants.AWS_LAMBDA_INITIALIZATION_TYPE, value = LambdaConstants.ON_DEMAND_INVOCATION_TYPE)
void isColdStart() {
boolean isColdStart = LambdaHandlerProcessor.isColdStart();

Expand Down
1 change: 0 additions & 1 deletion powertools-idempotency/powertools-idempotency-dynamodb/pom.xml
View file
Open in desktop
Copy link
Contributor

@phipag phipag Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert all changes in this file.

Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,6 @@
<scope>test</scope>
</dependency>
</dependencies>

<profiles>
<profile>
<id>generate-graalvm-files</id>
Expand Down
684 changes: 350 additions & 334 deletions ...azon/lambda/powertools/idempotency/persistence/dynamodb/DynamoDBPersistenceStoreTest.java
View file
Open in desktop
Copy link
Contributor

@phipag phipag Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert all changes in this file.

Large diffs are not rendered by default.

3 changes: 3 additions & 0 deletions powertools-logging/powertools-logging-log4j/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,9 @@
--add-opens java.base/java.util=ALL-UNNAMED
--add-opens java.base/java.lang=ALL-UNNAMED
</argLine>
<environmentVariables>
<AWS_LAMBDA_INITIALIZATION_TYPE>on-demand</AWS_LAMBDA_INITIALIZATION_TYPE>
</environmentVariables>
</configuration>
</plugin>
</plugins>
Expand Down
4 changes: 2 additions & 2 deletions ...org/apache/logging/log4j/layout/template/json/resolver/PowerToolsResolverFactoryTest.java
View file
Open in desktop
Copy link
Contributor

@phipag phipag Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert all changes in this file. (the addition of \r)

Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ void shouldLogInJsonFormat() {
File logFile = new File("target/logfile.json");
assertThat(contentOf(logFile)).contains(
"{\"level\":\"DEBUG\",\"message\":\"Test debug event\",\"cold_start\":true,\"function_arn\":\"arn:aws:lambda:us-east-1:123456789012:function:test\",\"function_memory_size\":128,\"function_name\":\"test-function\",\"function_request_id\":\"test-request-id\",\"function_version\":\"1\",\"service\":\"testLog4j\",\"timestamp\":")
.contains("\"xray_trace_id\":\"1-63441c4a-abcdef012345678912345678\",\"myKey\":\"myValue\"}\n");
.contains("\"xray_trace_id\":\"1-63441c4a-abcdef012345678912345678\",\"myKey\":\"myValue\"}\r\n");
}

@Test
Expand All @@ -89,7 +89,7 @@ void shouldLogInEcsFormat() {

File logFile = new File("target/ecslogfile.json");
assertThat(contentOf(logFile)).contains(
"\"ecs.version\":\"1.2.0\",\"log.level\":\"DEBUG\",\"message\":\"Test debug event\",\"service.name\":\"testLog4j\",\"service.version\":\"1\",\"log.logger\":\"software.amazon.lambda.powertools.logging.internal.handler.PowertoolsLogEnabled\",\"process.thread.name\":\"main\",\"cloud.provider\":\"aws\",\"cloud.service.name\":\"lambda\",\"cloud.region\":\"eu-central-1\",\"cloud.account.id\":\"123456789012\",\"faas.id\":\"arn:aws:lambda:us-east-1:123456789012:function:test\",\"faas.name\":\"test-function\",\"faas.version\":\"1\",\"faas.memory\":128,\"faas.execution\":\"test-request-id\",\"faas.coldstart\":true,\"trace.id\":\"1-63441c4a-abcdef012345678912345678\",\"myKey\":\"myValue\"}\n");
"\"ecs.version\":\"1.2.0\",\"log.level\":\"DEBUG\",\"message\":\"Test debug event\",\"service.name\":\"testLog4j\",\"service.version\":\"1\",\"log.logger\":\"software.amazon.lambda.powertools.logging.internal.handler.PowertoolsLogEnabled\",\"process.thread.name\":\"main\",\"cloud.provider\":\"aws\",\"cloud.service.name\":\"lambda\",\"cloud.region\":\"eu-central-1\",\"cloud.account.id\":\"123456789012\",\"faas.id\":\"arn:aws:lambda:us-east-1:123456789012:function:test\",\"faas.name\":\"test-function\",\"faas.version\":\"1\",\"faas.memory\":128,\"faas.execution\":\"test-request-id\",\"faas.coldstart\":true,\"trace.id\":\"1-63441c4a-abcdef012345678912345678\",\"myKey\":\"myValue\"}\r\n");
}

}
2 changes: 1 addition & 1 deletion ...rc/test/java/software/amazon/lambda/powertools/logging/internal/LambdaEcsEncoderTest.java
View file
Open in desktop
Copy link
Contributor

@phipag phipag Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert all changes in this file. (the addition of \r)

Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ void shouldLogException() {

// THEN (stack is logged with root cause first)
assertThat(result).contains(
"\"message\":\"Error\",\"error.message\":\"Unexpected value\",\"error.type\":\"java.lang.IllegalStateException\",\"error.stack_trace\":\"java.lang.IllegalStateException: Unexpected value\\n");
"\"message\":\"Error\",\"error.message\":\"Unexpected value\",\"error.type\":\"java.lang.IllegalStateException\",\"error.stack_trace\":\"java.lang.IllegalStateException: Unexpected value\\r\\n");
}

private void setMDC() {
Expand Down
Loading
Loading