Skip to content

Conversation

@knziiy
Copy link
Contributor

@knziiy knziiy commented Oct 16, 2025

Description of Changes

  • Add tagKey parameter: Added a new optional parameter.
  • Update tag application logic: Updated the main CDK app and the RAG Knowledge Base stack to use the configurable tag key.

Checklist

  • Modified relevant documentation
  • Verified operation in local environment
  • Executed npm run cdk:test and if there are snapshot differences, execute npm run cdk:test:update-snapshot to update snapshots

Related Issues

Note

Validation for the tagKey input value is not performed in this implementation.
This is because tagging specifications differ across AWS services, and we also do not currently validate the existing tagValue.
Instead, we rely on the validation checks performed by each respective AWS service during deployment.

@kazuhitogo kazuhitogo self-requested a review October 20, 2025 01:36
Copy link
Collaborator

@kazuhitogo kazuhitogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます。
packages/cdk/cdk.jsonにデフォルトで この設定を入れておいていただけますでしょうか?

@knziiy
Copy link
Contributor Author

knziiy commented Oct 23, 2025

@kazuhitogo
レビューありがとうございます。失礼しました、cdk.jsonへの追加が必要でしたね・・・
以下のとおり修正、テスト後追加でコミットさせていただきます。

--- a/packages/cdk/cdk.json
+++ b/packages/cdk/cdk.json
@@ -16,6 +16,7 @@
   },
   "context": {
     "env": "",
+    "tagKey": null,
     "tagValue": null,
     "ragEnabled": false,
     "kendraIndexArn": null,

@knziiy knziiy requested a review from kazuhitogo October 23, 2025 01:41
Copy link
Collaborator

@kazuhitogo kazuhitogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
ありがとうございます!

@kazuhitogo kazuhitogo merged commit c2ff542 into aws-samples:main Oct 23, 2025
2 checks passed
@knziiy knziiy deleted the feature/enable-tag-key-specification branch October 23, 2025 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants