-
Notifications
You must be signed in to change notification settings - Fork 53
Add tolerance #243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add tolerance #243
Conversation
| } | ||
| }, | ||
| "MaxConcurrency": 60, | ||
| "ToleratedFailurePercentage": 10, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@esc1144 for discussion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this will affect all/most modules, what to you think about making the value (i.e. 10%) a parameter that we set in the SF resource declaration in the modules. We would then need to collect a new parameter for it on the main template to pass along to the nested ones. But if a cx ever wanted to adjust it from the 10% default, it would easy to just run a stack update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are several general options:
- All 100% Green = Everybody is happy
- All 100% Red = there is a totall miss in the permissions and we need to fail the full data collection step function
- X% are RED - most probably we do not need to fail ALL data collection as some data are collected and we need to run crawler anyway. The data will be partial, sure but there will be at least some of them. The % of failed and other interesting things we need to address in other PR in progress.
Here in the option 3 the number is not that significant. I will update it to 90% so that even 10% of success would count as success.
Again reminder that today we have all green whatever the result of SFs ;)
| } | ||
| }, | ||
| "MaxConcurrency": 60, | ||
| "ToleratedFailurePercentage": 10, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this will affect all/most modules, what to you think about making the value (i.e. 10%) a parameter that we set in the SF resource declaration in the modules. We would then need to collect a new parameter for it on the main template to pass along to the nested ones. But if a cx ever wanted to adjust it from the 10% default, it would easy to just run a stack update.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.