refactor: dynamically generate command list #3206
Open
+63
−55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Konippi
force-pushed
the
dynamically-generate-command-list
branch
from
0e2791b to
b06d192
Compare
kkashilk
reviewed
Oct 20, 2025
| } | ||
|
|
||
| // If this command has subcommands, add them too | ||
| if subcommand.has_subcommands() { |
There was a problem hiding this comment.
Does this cover the case /context show --expand
There was a problem hiding this comment.
Looks like we're also missing these now -
"/hooks add",
"/hooks rm",
"/hooks enable",
"/hooks disable",
"/hooks enable-all",
"/hooks disable-all",
There was a problem hiding this comment.
I'd recommend adding the existing commands as tests here -
Don't need to commit all of those in, only for local testing
There was a problem hiding this comment.
Does this cover the case /context show --expand
Why does it only support the “/context show --expand” option? It should only support slash commands and their subcommands.
Looks like we're also missing these now -
"/hooks add",
"/hooks rm",
"/hooks enable",
"/hooks disable",
"/hooks enable-all",
"/hooks disable-all",These subcommands should not exist at present.
kkashilk
reviewed
Oct 20, 2025
| .iter() | ||
| .filter(|p| p.starts_with(word)) | ||
| .map(|s| (*s).to_owned()) | ||
| .map(|s| s.to_string()) |
There was a problem hiding this comment.
Also, seeing this clippy error -
error: calling `to_string` on `&&str`
--> crates/chat-cli/src/cli/chat/prompt.rs:127:22
|
127 | .map(|s| s.to_string())
| ^^^^^^^^^^^^^ help: try dereferencing the receiver: `(*s).to_string()`
|
= help: `&str` implements `ToString` through a slower blanket impl, but `str` has a fast specialization of `ToString`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inefficient_to_string
= note: `-D clippy::inefficient-to-string` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::inefficient_to_string)]`
error: could not compile `chat_cli` (lib) due to 1 previous error
Can you run -
cargo clippy --locked --workspace --color always -- -D warnings
cargo +nightly fmt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#3185
Description of changes:
Replace static
COMMANDSarray with dynamic generation to automatically sync available commands with SlashCommandenum definition. This prevents inconsistencies like #3185 where unimplemented commands (e.g.,
/hooks help) appeared in the command list.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.