-
Notifications
You must be signed in to change notification settings - Fork 4.3k
feat(s3-deployment): support cross-region deployments with destinationBucketRegion parameter #35703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bentorb
wants to merge
11
commits into
aws:main
Choose a base branch
from
bentorb:fix/s3-deployment-cross-region-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…region deployments - Add destinationBucketRegion parameter to BucketDeployment construct - Fix cross-region S3 deployments to opt-in regions like eu-south-2 - Update Lambda handler to use correct region for S3 operations - Add comprehensive integration tests covering 8 cross-region scenarios - Validate deployments across us-east-1, us-west-2, and eu-south-2 Fixes cross-region deployment failures when deploying to regions that require explicit opt-in.
aws-cdk-automation
previously requested changes
Oct 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
…n deployment - Add test cases 9 and 10 for eu-south-2 to us-west-2 cross-region scenarios - Test both with and without destinationBucketRegion parameter specified - Update integration test snapshots with new CloudFormation templates - Validate cross-region deployment functionality works correctly
- Removed unnecessary text
…ption Replace the existing description for destinationBucketRegion with a more detailed one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
beginning-contributor
[Pilot] contributed between 0-2 PRs to the CDK
effort/medium
Medium work item – several days of effort
feature-request
A feature should be added or improved.
p2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34858
This PR adds support for cross-region S3 deployments by introducing an optional
destinationBucketRegion
parameter to theBucketDeployment
construct.Motivation
Cross-region S3 deployments currently fail when deploying from opt-in AWS regions (like
eu-south-2
) because the Lambda handler does not include de--region
required in the S3 CLI operations.Solution
destinationBucketRegion
parameter toBucketDeploymentProps
Testing
Breaking Changes
None - this is a backward-compatible feature addition.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license