Skip to content

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 19, 2025

Bumps awscrt from 0.27.6 to 0.28.1.

Also exposes new CRT S3 client parameters to control file IO: should_stream, disk_throughput, and direct_io via the shared config file. https://github.com/awslabs/aws-crt-python/blob/e6a48db2b9c16288af5ae0b8bd5269eb9d3c3c02/awscrt/s3.py#L146-L179

Preview of docs for new s3 configs:
image
image
image

@dependabot dependabot bot added dependencies This issue is a problem in a dependency. v2 labels Sep 19, 2025
@hssyoo hssyoo force-pushed the dependabot/pip/v2/awscrt-0.28.1 branch from 3bc78a0 to 7eea2ff Compare September 19, 2025 17:42
@hssyoo hssyoo self-assigned this Sep 19, 2025
dependabot bot and others added 7 commits September 23, 2025 14:33
Bumps [awscrt](https://github.com/awslabs/aws-crt-python) from 0.27.6 to 0.28.1.
- [Release notes](https://github.com/awslabs/aws-crt-python/releases)
- [Commits](awslabs/aws-crt-python@v0.27.6...v0.28.1)

---
updated-dependencies:
- dependency-name: awscrt
  dependency-version: 0.28.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@hssyoo hssyoo force-pushed the dependabot/pip/v2/awscrt-0.28.1 branch from 845a73e to eb02eea Compare September 23, 2025 18:34
Copy link
Contributor

@AndrewAsseily AndrewAsseily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two minor comments/questions

**Default** - ``10.0``

The estimated target disk throughput. This value is only applied if
``should_stream`` is set to ``true``.This value can be specified using
Copy link
Contributor

@AndrewAsseily AndrewAsseily Sep 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit: There's a missing space after true.

Copy link
Contributor

@AndrewAsseily AndrewAsseily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a minor nit and hit retry on the failing CI test, but LGTM to me assuming that passes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies This issue is a problem in a dependency. v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants