-
Notifications
You must be signed in to change notification settings - Fork 4.4k
Bump awscrt from 0.27.6 to 0.28.1 #9735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v2
Are you sure you want to change the base?
Conversation
3bc78a0
to
7eea2ff
Compare
Bumps [awscrt](https://github.com/awslabs/aws-crt-python) from 0.27.6 to 0.28.1. - [Release notes](https://github.com/awslabs/aws-crt-python/releases) - [Commits](awslabs/aws-crt-python@v0.27.6...v0.28.1) --- updated-dependencies: - dependency-name: awscrt dependency-version: 0.28.1 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
845a73e
to
eb02eea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two minor comments/questions
**Default** - ``10.0`` | ||
|
||
The estimated target disk throughput. This value is only applied if | ||
``should_stream`` is set to ``true``.This value can be specified using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nit: There's a missing space after true
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a minor nit and hit retry on the failing CI test, but LGTM to me assuming that passes.
Bumps awscrt from 0.27.6 to 0.28.1.
Also exposes new CRT S3 client parameters to control file IO:
should_stream
,disk_throughput
, anddirect_io
via the shared config file. https://github.com/awslabs/aws-crt-python/blob/e6a48db2b9c16288af5ae0b8bd5269eb9d3c3c02/awscrt/s3.py#L146-L179Preview of docs for new s3 configs:


