Conversation
bretambrose
reviewed
Sep 24, 2025
Contributor
bretambrose
left a comment
bretambrose
left a comment
There was a problem hiding this comment.
Do we want cipher suite on the static builder functions or as a separate API?
Contributor
Author
Python SDK static builder function directly return a mqtt5 client / mqtt3 connection. We don't really have a way to add a separate API for builder. |
xiazhvera
changed the title
Contributor
|
|
sfod
reviewed
Nov 21, 2025
awsiot/mqtt_connection_builder.py
Outdated
| if port == 443 and awscrt.io.is_alpn_available() and use_custom_authorizer is False: | ||
| tls_ctx_options.alpn_list = ['http/1.1'] if use_websockets else ['x-amzn-mqtt-ca'] | ||
|
|
||
| if cipher_pref != awscrt.io.TlsCipherPref.DEFAULT: |
Contributor
There was a problem hiding this comment.
mqtt5 builder has a check for None. Should it be the same here?
Contributor
Author
There was a problem hiding this comment.
Nice catch. Instead, added validation assert isinstance(cipher_pref, awscrt.io.TlsCipherPref) instead.
sfod
approved these changes
Nov 24, 2025
…on-v2 into cipher_suite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.