chore(clients): use rollup for dist-cjs #7406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhe
force-pushed
the
chore/build
branch
2 times, most recently
from
dc1b11c to
1858995
Compare
trivikr
approved these changes
Oct 8, 2025
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
internal JS-6272
Description
see smithy-lang/smithy-typescript#1713
uses rollup instead of esbuild to generate the dist-cjs distribution
Testing
CI should suffice - this change affects cjs build artifacts, which are what run in Node.js, i.e. most of our automated test suite.
Checklist
*.integ.spec.ts).@publictag and enable doc generation on the package?