Skip to content

Conversation

@smilkuri
Copy link
Contributor

@smilkuri smilkuri commented Oct 9, 2025

Issue

Internal JS-6273

Description

Apply reservedWords.escape() to union shape names when generating the visitor pattern code to avoid TypeScript compilation errors when union names conflict with reserved words like 'Parameters'.

Testing

Locally

yarn build:all

 Tasks:    516 successful, 516 total
Cached:    42 cached, 516 total
  Time:    15m45.413s 

    ...Finishing writing to cache...                                                                                                                                                                                                                           WARNING  no output files found for task @aws-sdk/aws-middleware-test#build. Please check your `outputs` key in `turbo.json`

Checklist

  • [n/a] If the PR is a feature, add integration tests (*.integ.spec.ts).
  • [n/a] If you wrote E2E tests, are they resilient to concurrent I/O?
  • [n/a] If adding new public functions, did you add the @public tag and enable doc generation on the package?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@smilkuri smilkuri requested a review from a team as a code owner October 9, 2025 21:21
@smilkuri smilkuri merged commit 9ee6cdc into main Oct 9, 2025
8 checks passed
@smilkuri smilkuri deleted the timestream-influxdb branch October 9, 2025 23:00
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants