Skip to content

fix: remove InvalidChangeBatch customization #1435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Oct 11, 2024
Merged

fix: remove InvalidChangeBatch customization #1435

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
352ef1c
Remove InvalidChangeBatch customization
lauzadis Oct 7, 2024
4cc6946
revert test deletion
lauzadis Oct 7, 2024
be60729
Changelog
lauzadis Oct 7, 2024
9740446
error response
lauzadis Oct 8, 2024
dadf763
Add E2E test
lauzadis Oct 8, 2024
b084874
Configure region
lauzadis Oct 8, 2024
142eec9
Change error message
lauzadis Oct 9, 2024
1f61f00
Remove println
lauzadis Oct 9, 2024
acc251c
Remove assertion on error message contents
lauzadis Oct 11, 2024
9d04768
ktlint
lauzadis Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .changes/a9deee4f-8f15-472c-906f-492066275178.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"id": "a9deee4f-8f15-472c-906f-492066275178",
"type": "bugfix",
"description": "Remove Route53 InvalidChangeBatch customization",
Copy link
Contributor

@0marperez 0marperez Oct 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: It would be more descriptive to mention that the customization deals with error responses, e.g. Remove Route53 InvalidChangeBatch error response customization

"issues": [
"https://github.com/awslabs/aws-sdk-kotlin/issues/1433"
]
}
42 changes: 0 additions & 42 deletions .../kotlin/codegen/customization/route53/ChangeResourceRecordSetsUnmarshallingIntegration.kt
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion ...ces/META-INF/services/software.amazon.smithy.kotlin.codegen.integration.KotlinIntegration
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ aws.sdk.kotlin.codegen.customization.glacier.GlacierBodyChecksum
aws.sdk.kotlin.codegen.customization.polly.PollyPresigner
aws.sdk.kotlin.codegen.customization.machinelearning.MachineLearningEndpointCustomization
aws.sdk.kotlin.codegen.customization.route53.TrimResourcePrefix
aws.sdk.kotlin.codegen.customization.route53.ChangeResourceRecordSetsUnmarshallingIntegration
aws.sdk.kotlin.codegen.customization.ec2.EC2MakePrimitivesOptional
aws.sdk.kotlin.codegen.customization.RemoveDefaults
aws.sdk.kotlin.codegen.customization.s3.UnsupportedSigningAlgorithmIntegration
Expand Down
40 changes: 0 additions & 40 deletions ...lin/codegen/customization/route53/ChangeResourceRecordSetsUnmarshallingIntegrationTest.kt
View file
Open in desktop

This file was deleted.

49 changes: 0 additions & 49 deletions ...mon/src/aws/sdk/kotlin/services/route53/internal/ChangeResourceRecordSetsUnmarshalling.kt
View file
Open in desktop

This file was deleted.

109 changes: 0 additions & 109 deletions ...est/aws/sdk/kotlin/services/route53/internal/ChangeResourceRecordSetsUnmarshallingTest.kt
View file
Open in desktop

This file was deleted.

Loading