Update mapping.json for response/request mapping to latest version #4086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the response mapping logic between S3 SDK response objects (PutObjectResponse, CompleteMultipartUploadResponse) and the Transfer Utility's TransferUtilityUploadResponse class. The changes expand the mapped properties to include additional fields like BucketName, Key, Location, and Size, along with configuration file updates and test improvements.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/src/Services/S3/Custom/Transfer/TransferUtilityUploadResponse.cs | Added new properties: BucketName, Key, Location, and Size with documentation |
| sdk/src/Services/S3/Custom/Transfer/Internal/ResponseMapper.cs | Updated mapping methods to include new properties for both PutObject and CompleteMultipartUpload responses |
| sdk/test/Services/S3/UnitTests/Custom/EmbeddedResource/mapping.json | Added property mappings for new fields in both request and response conversions |
| sdk/test/Services/S3/UnitTests/Custom/EmbeddedResource/property-aliases.json | Added BucketName alias mappings for response types |
| sdk/test/Services/S3/UnitTests/Custom/ResponseMapperTests.cs | Fixed test value generation for int/long types and corrected usesHeadersCollection flag |
| generator/.DevConfigs/7f23582e-3225-487b-83e7-167cf17cb238.json | Added dev config for patch version update |
GarrettBeatty
changed the title
GarrettBeatty
commented
Oct 29, 2025
| return simpleUploadCommand.ConstructRequest(); | ||
| }, | ||
| usesHeadersCollection: false, | ||
| usesHeadersCollection: true, |
There was a problem hiding this comment.
since CacheControl was added to mapping and thats located in headers we have to search there now
peterrsongg
approved these changes
Oct 29, 2025
philasmar
approved these changes
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update mapping.json for response/request mapping to latest version
Description
Update mapping.json for response/request mapping to latest version. Also update corresponding classes to compensate for those changes.
Motivation and Context
To comply with the SEP
Testing
Types of changes
Checklist
License