Skip to content

[V3] Rename ErrorType exception properties to avoid hiding inherited member #4089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2025
Merged

[V3] Rename ErrorType exception properties to avoid hiding inherited member #4089

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions generator/.DevConfigs/e2fd4917-66af-4f7a-a019-8c8fec7a1899.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@


{
"services": [
{
"serviceName": "Account",
"type": "patch",
"changeLogMessages": [
"Rename internal exception property to avoid hiding inherited AmazonServiceException member."
]
}
]
}
4 changes: 4 additions & 0 deletions generator/ServiceClientGeneratorLib/Member.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,6 +253,10 @@ public string BasePropertyName
}
}

// Rename ErrorType exception properties to avoid hiding AmazonServiceException.ErrorType inherited member.
if (OwningShape.IsException && _name.ToUpperFirstCharacter() == "ErrorType")
return "RequestErrorType";

return _name.ToUpperFirstCharacter();
}
}
Expand Down
13 changes: 0 additions & 13 deletions generator/ServiceModels/account/account.customizations.json
View file
Open in desktop

This file was deleted.

8 changes: 4 additions & 4 deletions sdk/src/Services/Account/Generated/Model/AccessDeniedException.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ namespace Amazon.Account.Model
#endif
public partial class AccessDeniedException : AmazonAccountException
{
private string _requestErrorType;
private string _errorType;

/// <summary>
/// Constructs a new AccessDeniedException with the specified error
Expand Down Expand Up @@ -133,14 +133,14 @@ public override void GetObjectData(System.Runtime.Serialization.SerializationInf
/// </summary>
public string RequestErrorType
{
get { return this._requestErrorType; }
set { this._requestErrorType = value; }
get { return this._errorType; }
set { this._errorType = value; }
}

// Check to see if RequestErrorType property is set
internal bool IsSetRequestErrorType()
{
return !string.IsNullOrEmpty(this._requestErrorType);
return !string.IsNullOrEmpty(this._errorType);
}

}
Expand Down
8 changes: 4 additions & 4 deletions sdk/src/Services/Account/Generated/Model/ConflictException.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ namespace Amazon.Account.Model
#endif
public partial class ConflictException : AmazonAccountException
{
private string _requestErrorType;
private string _errorType;

/// <summary>
/// Constructs a new ConflictException with the specified error
Expand Down Expand Up @@ -135,14 +135,14 @@ public override void GetObjectData(System.Runtime.Serialization.SerializationInf
/// </summary>
public string RequestErrorType
{
get { return this._requestErrorType; }
set { this._requestErrorType = value; }
get { return this._errorType; }
set { this._errorType = value; }
}

// Check to see if RequestErrorType property is set
internal bool IsSetRequestErrorType()
{
return !string.IsNullOrEmpty(this._requestErrorType);
return !string.IsNullOrEmpty(this._errorType);
}

}
Expand Down
8 changes: 4 additions & 4 deletions sdk/src/Services/Account/Generated/Model/InternalServerException.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ namespace Amazon.Account.Model
#endif
public partial class InternalServerException : AmazonAccountException
{
private string _requestErrorType;
private string _errorType;

private RetryableDetails _retryableDetails = new RetryableDetails(false);

Expand Down Expand Up @@ -135,14 +135,14 @@ public override void GetObjectData(System.Runtime.Serialization.SerializationInf
/// </summary>
public string RequestErrorType
{
get { return this._requestErrorType; }
set { this._requestErrorType = value; }
get { return this._errorType; }
set { this._errorType = value; }
}

// Check to see if RequestErrorType property is set
internal bool IsSetRequestErrorType()
{
return !string.IsNullOrEmpty(this._requestErrorType);
return !string.IsNullOrEmpty(this._errorType);
}

/// <summary>
Expand Down
8 changes: 4 additions & 4 deletions sdk/src/Services/Account/Generated/Model/ResourceNotFoundException.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ namespace Amazon.Account.Model
#endif
public partial class ResourceNotFoundException : AmazonAccountException
{
private string _requestErrorType;
private string _errorType;

/// <summary>
/// Constructs a new ResourceNotFoundException with the specified error
Expand Down Expand Up @@ -132,14 +132,14 @@ public override void GetObjectData(System.Runtime.Serialization.SerializationInf
/// </summary>
public string RequestErrorType
{
get { return this._requestErrorType; }
set { this._requestErrorType = value; }
get { return this._errorType; }
set { this._errorType = value; }
}

// Check to see if RequestErrorType property is set
internal bool IsSetRequestErrorType()
{
return !string.IsNullOrEmpty(this._requestErrorType);
return !string.IsNullOrEmpty(this._errorType);
}

}
Expand Down
8 changes: 4 additions & 4 deletions sdk/src/Services/Account/Generated/Model/TooManyRequestsException.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ namespace Amazon.Account.Model
#endif
public partial class TooManyRequestsException : AmazonAccountException
{
private string _requestErrorType;
private string _errorType;

private RetryableDetails _retryableDetails = new RetryableDetails(true);

Expand Down Expand Up @@ -135,14 +135,14 @@ public override void GetObjectData(System.Runtime.Serialization.SerializationInf
/// </summary>
public string RequestErrorType
{
get { return this._requestErrorType; }
set { this._requestErrorType = value; }
get { return this._errorType; }
set { this._errorType = value; }
}

// Check to see if RequestErrorType property is set
internal bool IsSetRequestErrorType()
{
return !string.IsNullOrEmpty(this._requestErrorType);
return !string.IsNullOrEmpty(this._errorType);
}

/// <summary>
Expand Down