Skip to content

feat(amazonq): discard edits suggestion when the cursor is too far away #8174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 15, 2025
Merged

feat(amazonq): discard edits suggestion when the cursor is too far away #8174

merged 4 commits into from
Oct 15, 2025
+120 −16

Conversation

@atonaamz
Copy link
Contributor

@atonaamz atonaamz commented Oct 13, 2025 •
edited
Loading

Problem

If suggestion is at least 10 lines away, we don't want to show it to the user.

Solution

discard edits suggestion when the cursor position is at least 10 lines away

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@atonaamz atonaamz requested a review from a team as a code owner October 13, 2025 23:23
@amazon-inspector-ohio
Copy link

⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done

@github-actions
Copy link

  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@amazon-inspector-ohio
Copy link

✅ I finished the code review, and didn't find any security or code quality issues.

@atonaamz atonaamz force-pushed the cursormove branch 3 times, most recently from 56ba3a2 to d67774b Compare October 14, 2025 17:49
@atonaamz
Copy link
Contributor Author

/retryBuilds

atonaamz
atonaamz commented Oct 14, 2025
View reviewed changes
packages/amazonq/src/app/inline/EditRendering/displayImage.ts
const endPosition = getEndOfEditPosition(originalCode, newCode)
editor.selection = new vscode.Selection(endPosition, endPosition)

// Move cursor to end of the actual changed content
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicate code so removing

@atonaamz atonaamz closed this Oct 14, 2025
@atonaamz atonaamz reopened this Oct 14, 2025
@amazon-inspector-ohio
Copy link

⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done

@amazon-inspector-ohio
Copy link

✅ I finished the code review, and didn't find any security or code quality issues.

@atonaamz
Copy link
Contributor Author

/retryBuilds

@atonaamz atonaamz closed this Oct 14, 2025
@atonaamz atonaamz reopened this Oct 14, 2025
@amazon-inspector-ohio
Copy link

⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done

@amazon-inspector-ohio
Copy link

✅ I finished the code review, and didn't find any security or code quality issues.

@atonaamz
Copy link
Contributor Author

/retryBuilds

@atonaamz atonaamz closed this Oct 14, 2025
@atonaamz atonaamz reopened this Oct 14, 2025
@amazon-inspector-ohio
Copy link

⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done

@amazon-inspector-ohio
Copy link

✅ I finished the code review, and didn't find any security or code quality issues.

@atonaamz
Copy link
Contributor Author

/retryBuilds

@atonaamz
Copy link
Contributor Author

/retryBuilds

@atonaamz atonaamz closed this Oct 15, 2025
@atonaamz atonaamz reopened this Oct 15, 2025
@amazon-inspector-ohio
Copy link

⏳ I'm reviewing this pull request for security vulnerabilities and code quality issues. I'll provide an update when I'm done

@amazon-inspector-ohio
Copy link

✅ I finished the code review, and didn't find any security or code quality issues.

@atonaamz
Copy link
Contributor Author

/retryBuilds

@atonaamz
Copy link
Contributor Author

/retryBuilds

@atonaamz
Copy link
Contributor Author

/retryBuild

@atonaamz
Copy link
Contributor Author

/retryBuild

@atonaamz atonaamz merged commit e476550 into aws:master Oct 15, 2025
77 of 95 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Will-ShaoHua Will-ShaoHua Will-ShaoHua approved these changes

@bywang56 bywang56 bywang56 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@atonaamz @Will-ShaoHua @bywang56