feat: Add OpenSSL 3.5.1 support to nix-based development shells #5431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johubertj
commented
Jul 18, 2025
| shellHook = '' | ||
| echo Setting up $S2N_LIBCRYPTO environment from flake.nix... | ||
| export OPENSSL_PATH=${openssl_3_5_1} | ||
| export PATH=$OPENSSL_PATH/bin:$PATH |
There was a problem hiding this comment.
This shellHook sets up the environment so the OpenSSL 3.5.1 binary and its required shared libraries are correctly found at runtime. We had to add it because our custom-built OpenSSL 3.5.1 lacks Nix’s wrappers, so LD_LIBRARY_PATH must be set manually to avoid library loading errors.
johubertj
changed the title
|
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Added support for OpenSSL 3.5.1 in s2n-tls (in nix)
Testing:
Manual testing was performed to verify the environment setup. Specifically:
Ran
nix develop .#openssl351to enter the new devShell.Verified the correct OpenSSL binary was used:
which openssl->/nix/store/b6l67vj4v1b30ayf5m13hn2nmamjxz7p-openssl-3.5.1/bin/opensslSet LD_LIBRARY_PATH to include the OpenSSL 3.5.1 lib directory and confirmed:
openssl version->OpenSSL 3.5.1 30 Jan 2024Ran
uvinteg test_pq_handshaketo confirm the integration test could run using the new provider.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.