add typo check to ci #5491
add typo check to ci #5491
Conversation
Followed the s2n-quic example, as aws#5051 suggests.
|
I think the only thing missing from this being perfect is what to do about |
|
I do also see that I missed |
|
Hello @brimonk, Thanks for cutting this PR to us, and thanks for attempting to improve our CI! I have assigned reviewers for this PR, and we will take a look. |
| # While we build up the extend-words list | ||
| [type.cpp] | ||
| check-file = false |
There was a problem hiding this comment.
Maybe I'm misunderstanding the documentation, but doesn't this have the same effect as adding "*.cpp" to extend-exclude below? Mixing the two ignore mechanisms might be confusing. Like, it seems odd that we ignore .c files via type.c but ignore .h files via extend-exclude.
In general I'm having a hard time figuring out what files this check is and isn't currently running on. Comments might help, but maybe we should also be running "typos --files" as part of the action?
|
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
|
||
| [type.cmake.extend-words] | ||
| # 'thr' is the FreeBSD threading library | ||
| thr = "thr" |
There was a problem hiding this comment.
| thr = "thr" | |
| thr = "thr" | |
| testss = "testss" |
|
Getting back to this... some additional mistakes have crept in, if we can get those last few corrections updated we can get this merged. |
5 participants
Resolved issues:
resolves #5051
Description of changes:
Added the
typoscheck as per the suggestions in #5051, with a duplication of the typos check ins2n-quic. Also fixed a few typos as I went along.Testing:
I opened up a PR against my fork of the repo, and can confirm that the
typoscheck will fail if there are files that fail thetyposcheck.(History is weird because I felt the need to squash the PR before making this PR)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.