Skip to content

chore(ci): add openssl-1.0.2-fips gcc-4.8 job #5512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2025
Merged

chore(ci): add openssl-1.0.2-fips gcc-4.8 job #5512

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions codebuild/spec/buildspec_generalbatch.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,6 +227,17 @@ batch:
S2N_LIBCRYPTO: 'libressl'
TESTS: unit
identifier: s2nUnitLibressl
- buildspec: codebuild/spec/buildspec_ubuntu.yml
env:
compute-type: BUILD_GENERAL1_SMALL
image: 024603541914.dkr.ecr.us-west-2.amazonaws.com/docker:ubuntu18codebuild
privileged-mode: true
variables:
BUILD_S2N: 'true'
GCC_VERSION: '4.8'
S2N_LIBCRYPTO: 'openssl-1.0.2-fips'
TESTS: unit
identifier: s2nUnitOpenssl102FipsGcc48
Comment on lines +230 to +240
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, was our discussion that we needed a basic unit test to fill that gap? Minimally we'd want an AddressSanitizer, but I think the context of our discussion was integ testing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've got all three in PR:

- buildspec: codebuild/spec/buildspec_ubuntu.yml
env:
compute-type: BUILD_GENERAL1_SMALL
Expand Down
Loading