Skip to content

bench: increase benchmark throughput data size #5587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

bench: increase benchmark throughput data size #5587

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4616a46
Increase benchmark throughput data size
kaukabrizvi Oct 27, 2025
1483f93
Merge branch 'main' into mod-bench-throughput
kaukabrizvi Oct 27, 2025
87ca9db
move comment to top-level from inline
kaukabrizvi Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions bindings/rust/standard/benchmarks/benches/throughput.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@ fn bench_throughput_for_library<T>(
}

pub fn bench_throughput_cipher_suites(c: &mut Criterion) {
// arbitrarily large to cut across TLS record boundaries
let mut shared_buf = [0u8; 100000];
// 10MB buffer - arbitrarily large to cut across TLS record boundaries.
let mut shared_buf = vec![0u8; 10_000_000];
Comment on lines 45 to +47
Copy link
Contributor

@lrstewart lrstewart Oct 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the right 10MB? I'm not super familiar with the benchmark tests, and I also see

s2n-tls/bindings/rust/standard/benchmarks/src/test_utilities.rs

Line 18 in 6aefe74

let mut buf = [0x56u8; 1000000];

Did you just test that all benchmarks passed, or did you somehow confirm that all benchmark tests now send more data / take longer? Can you expand your "Testing" section with more details about how you know this change achieves what you're trying to achieve?

Copy link
Contributor Author

@kaukabrizvi kaukabrizvi Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the right 10 MB to configure buffer size for throughput benchmarks. To address the second point, I inspected the benchmark results more closely and found that s2n-tls performs significantly faster than expected at 10 MB. I'm currently exploring this and will follow up once I've gathered sufficient data and have more clarity on this behavior.


for cipher_suite in CipherSuite::iter() {
let mut bench_group = c.benchmark_group(format!("throughput-{cipher_suite:?}"));
Expand Down
Loading