Skip to content

fix(http): use user-provided ClientBootstrap in HttpConnection#823

Open
abhu85 wants to merge 2 commits intoawslabs:mainfrom
abhu85:fix/http-connection-bootstrap-819
Open

fix(http): use user-provided ClientBootstrap in HttpConnection#823
abhu85 wants to merge 2 commits intoawslabs:mainfrom
abhu85:fix/http-connection-bootstrap-819

Conversation

@abhu85
Copy link

@abhu85 abhu85 commented Feb 18, 2026

Summary

Fix condition that checked uninitialized options.bootstrap (always null after AWS_ZERO_STRUCT) instead of connectionOptions.Bootstrap. This caused user-provided ClientBootstrap to never be used.

Changes

  • Changed line 136 in source/http/HttpConnection.cpp from checking options.bootstrap to connectionOptions.Bootstrap

Test plan

  • Code review passed
  • Build tests (requires CMake + submodules setup)

Fixes #819

Fix condition that checked uninitialized options.bootstrap (always null after AWS_ZERO_STRUCT) instead of connectionOptions.Bootstrap. This caused user-provided ClientBootstrap to never be used.

Fixes awslabs#819
@abhu85
Copy link
Author

abhu85 commented Mar 3, 2026

Friendly ping for review. This is a 1-line fix for #819 where the user-provided ClientBootstrap was being ignored due to checking the wrong variable (options.bootstrap which is always null after AWS_ZERO_STRUCT instead of connectionOptions.Bootstrap).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HttpConnection always uses the default ClientBootstrap

1 participant