Open
Conversation
… versions properly
bretambrose
reviewed
Feb 26, 2026
TingDaoK
reviewed
Mar 2, 2026
Comment on lines
+51
to
+53
| # Raspberry Pi builds that require QEMU emulation | ||
| raspberry: | ||
| runs-on: ubuntu-24.04 # latest |
Contributor
There was a problem hiding this comment.
you can move raspberry pi test to run on arm ubuntu instance. It's armv8 so that you don't need qemu.
like what we did for python here
Also the alpine-3.16-arm64 can benefit from the same setting.
| run: | | ||
| aws s3 cp s3://aws-crt-test-stuff/ci/${{ env.BUILDER_VERSION }}/linux-container-ci.sh ./linux-container-ci.sh && chmod a+x ./linux-container-ci.sh | ||
| ./linux-container-ci.sh ${{ env.BUILDER_VERSION }} aws-crt-${{ matrix.image }} build -p ${{ env.PACKAGE_NAME }} | ||
| ./linux-container-ci.sh ${{ env.BUILDER_VERSION }} aws-crt-ubuntu-20-x64 build -p ${{ env.PACKAGE_NAME }} --compiler=clang-latest --cmake-extra=-DUSE_OPENSSL=ON |
Contributor
There was a problem hiding this comment.
why not add the latest to the same metrics above?
Contributor
Author
There was a problem hiding this comment.
ubuntu-18-x64 can only find up to clang 19 while ubuntu-20-x64 finds clang 21. We can probably add clang-latest to ubuntu-18-x64 as well but I think we're moving away from testing middle versions beyond min and latest.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
clang-latestusing our latest version of ubuntu to test.Related aws-crt-builder PR: awslabs/aws-crt-builder#343
Splits out slower ci jobs into its own workflow to allow faster retry of normal speed CI jobs that fail on flaky tests without cancelling the longer running jobs.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.