Add autoconfiguration for AcknowledgementResultCallback components#1584
Open
rviniciussouza wants to merge 4 commits intoawspring:mainfrom
Open
Add autoconfiguration for AcknowledgementResultCallback components#1584rviniciussouza wants to merge 4 commits intoawspring:mainfrom
rviniciussouza wants to merge 4 commits intoawspring:mainfrom
Conversation
Contributor
tomazfernandes
left a comment
There was a problem hiding this comment.
Thanks for the PR @rviniciussouza.
Can you add an example in the docs under the Acknowledgement Result Callback section?
You can use the ErrorHandler section as reference.
Thanks.
Contributor
tomazfernandes
left a comment
There was a problem hiding this comment.
@rviniciussouza looks good, thanks!
#1562 introduced a conflict in the docs, you might need to do some reordering so the flow makes sense.
Also, please add "Since 4.1.0" for the new behavior.
Author
|
Hi, @tomazfernandes . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Add auto-configuration for
AcknowledgementResultCallbackandAsyncAcknowledgementResultCallbackin the default SQS listener container factory.💡 Motivation and Context
Only
AsyncAcknowledgementResultCallbackandAcknowledgementResultCallbackcurrently require manual wiring in the default SqsListenerContainerFactory.This PR removes that requirement by automatically attaching them when present in the application context.
Issue: #1583
💚 How did you test it?
SqsAutoConfigurationTestandLegacySqsAutoConfigurationTestto cover scenarios where the callbacks are either declared or absent.📝 Checklist
🔮 Next steps