Skip to content

Conversation

@halx99
Copy link
Collaborator

@halx99 halx99 commented Sep 24, 2025

"CanvasSize" better reflects the logical 2D space used for scene layout and initialization. Improves readability and avoids confusion with device resolution or safe area concepts.

Describe your changes

Issue ticket number and link

Checklist before requesting a review

For each PR

  • Add Copyright if it missed:
    - "Copyright (c) 2019-present Axmol Engine contributors (see AUTHORS.md)."

  • I have performed a self-review of my code.

    Optional:

    • I have checked readme and add important infos to this PR.
    • I have added/adapted some tests too.

For core/new feature PR

  • I have checked readme and add important infos to this PR.
  • I have added thorough tests.

Axmol 3.x ------------------------------------------------------------

For each 3.x PR

  • Check the '#include "axmol.h"' and replace it with the needed headers.

TODO:

mark: getFrameSize, setFrameSize, getWinSize, setFrameZoomFactor, getFrameZoomFactor in axmol-2.9.0

"CanvasSize" better reflects the logical 2D space used for scene layout and initialization.
Improves readability and avoids confusion with device resolution or safe area concepts.
@halx99
Copy link
Collaborator Author

halx99 commented Sep 24, 2025

/clang-format

@axmol-bot
Copy link
Collaborator

👋 @halx99 Command /clang-format received. Running code formatting, please wait...

@axmol-bot
Copy link
Collaborator

✅ Formatting completed and changes have been committed to the PR branch: rename-logical-size.
@halx99 please refresh to see the latest code.

@halx99 halx99 added this to the 3.0.0 milestone Sep 24, 2025
@halx99 halx99 added enhancement New feature or request breaking changes labels Sep 24, 2025
@halx99 halx99 marked this pull request as ready for review September 24, 2025 07:42
@halx99 halx99 merged commit 3e31feb into dev Sep 24, 2025
20 checks passed
@halx99 halx99 deleted the rename-logical-size branch September 24, 2025 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking changes enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants