Skip to content

Conversation

@Yehonal
Copy link
Member

@Yehonal Yehonal commented Jul 11, 2025

Refactor database configuration in the Docker setup to utilize environment variables for better flexibility and security.

@Yehonal Yehonal requested a review from Copilot July 11, 2025 10:22
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Refactors the Docker Compose setup to pull database connection values from environment variables with sensible defaults.

  • Switches fixed MySQL credentials to use ${VAR:-default} fallbacks
  • Updates the WordPress service to reference the same DB vars
  • Adds commented example entries for the new DB variables in .env.docker

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
docker-compose.yml Replaced static MySQL/WordPress credentials with environment fallbacks
.env.docker Added commented examples for new DOCKER_WORDPRESS_DB_* variables
Comments suppressed due to low confidence (1)

.env.docker:20

  • [nitpick] Add a short note or update the project README to explain these new database environment variables and how to override them for different environments.
# DOCKER_WORDPRESS_DB_ROOT_PASSWORD=flkdsjalfh

@Yehonal Yehonal merged commit f64a1a6 into azerothcore:master Jul 12, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant