Draft
Conversation
I've done a bit of researching and hacking about to see if I could make a Firefox Add-on version. It's displaying the OP button and the comment works. I've also manually copied the browser-poyfill.js file from the `node_modules/webextension-polyfill/dist/` directory. At this stage, it's all about webextension-polyfill trying to make things cross-browser compatible, but quite a bit more needs to be done to get it working and done professionally. And... it seems to have borked the commenting option in Chrome. Grrrr...
Owner
|
Thanks for this @siliconmeadow , will have a look later |
Author
|
No problem. It might be the wrong approach in the first place. I don't know how the build process works to get it in the Chrome store. Maybe the directory should be completely different. If the code for Chrome and FF are completely separated though, then there's no need for the |
Owner
|
No build process at the moment, but it makes sense to do so and most of the code can be shared with some conditional logic |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've done a bit of researching and hacking about to see if I could make a Firefox Add-on version.
It's displaying the OP button and the comment works. I've also manually copied the browser-poyfill.js file from the
node_modules/webextension-polyfill/dist/directory.At this stage, it's all about webextension-polyfill trying to make things cross-browser compatible, but quite a bit more needs to be done to get it working and done professionally.
And... it seems to have borked the commenting option in Chrome. Grrrr...