Processor being cached for each connection instead recreate #240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikitakuhta
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For every query processor creates and make deepClone of whole schema. It can take much time (100-300 ms with 300 models). Because of this, we have huge overhead in each query (query takes 1-5ms, deepClone takes 150ms). Very big problem is, that deepClone works synchronously, and whole application can be frozen, when many queries being executed.
In this pull request processor being cached in connection object, and no need to recreate it every query and make resource-expensive deepClone. Schema have no modifications in here, it don't need to be recreated every time.