Skip to content

Added array support to postgres adapter #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added array support to postgres adapter #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
47acc81
support for array type.
AnalogJ Aug 5, 2014
820b5a1
hard dependency on waterline-cursor 0.0.3 because of https://github.c…
AnalogJ Aug 12, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@ utils.sqlTypeCast = function(type) {
return 'TIMESTAMP WITH TIME ZONE';

case 'array':
return 'TEXT';
return 'text []';

case 'json':
return 'JSON';
Expand Down
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@
"lodash": "~2.4.1",
"async": "~0.9.0",
"waterline-errors": "~0.10.0",
"waterline-sequel": "~0.0.2",
"waterline-cursor": "~0.0.3"
"waterline-sequel": "git://github.com/AnalogJ/waterline-sequel.git",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is dangerous as it exposes users to waterline-sequel edge version.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • "waterline-sequel": "git://github.com/AnalogJ/waterline-sequel.git",

@AnalogJ Yea this is never going to happen. Just submit a PR to waterline-sequel and we'll merge the work in there. If you already have, then we'll take a look.

"waterline-cursor": "0.0.3"
},
"devDependencies": {
"mocha": "*",
Expand Down