Conversation
Contributor
tanut32039
commented
Mar 11, 2026
- If tss expired time is null -> not check expired time
RogerKSI
approved these changes
Mar 11, 2026
There was a problem hiding this comment.
Pull request overview
Adds support for optional TSS group expiration, allowing verification to proceed when a group has no configured expiry time.
Changes:
- Change
tss.groups[].expired_timefromu64toOption<u64>in config model. - Update TSS signature verification to skip expiry checks when
expired_timeisNone. - Update verifier tests to construct
Groupwithexpired_time: Some(...).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/verifier/tss/signature.rs |
Adjust expiry check logic to handle Option<u64> and update tests’ group construction. |
src/config/tss/group.rs |
Make expired_time optional in the config schema (Option<u64>). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
RogerKSI
approved these changes
Mar 11, 2026
Marca23
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.