Skip to content

[Feat] optional expired time#16

Merged
RogerKSI merged 3 commits intomainfrom
add-default-expired-time
Mar 11, 2026
Merged

[Feat] optional expired time#16
RogerKSI merged 3 commits intomainfrom
add-default-expired-time

Conversation

@tanut32039
Copy link
Contributor

  • If tss expired time is null -> not check expired time

@tanut32039 tanut32039 requested review from Marca23 and RogerKSI March 11, 2026 10:10
@RogerKSI RogerKSI requested a review from Copilot March 11, 2026 10:23
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support for optional TSS group expiration, allowing verification to proceed when a group has no configured expiry time.

Changes:

  • Change tss.groups[].expired_time from u64 to Option<u64> in config model.
  • Update TSS signature verification to skip expiry checks when expired_time is None.
  • Update verifier tests to construct Group with expired_time: Some(...).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/verifier/tss/signature.rs Adjust expiry check logic to handle Option<u64> and update tests’ group construction.
src/config/tss/group.rs Make expired_time optional in the config schema (Option<u64>).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@RogerKSI RogerKSI merged commit b9c99fd into main Mar 11, 2026
3 checks passed
@RogerKSI RogerKSI deleted the add-default-expired-time branch March 11, 2026 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants