Skip to content

Conversation

@pataar
Copy link
Contributor

@pataar pataar commented Oct 28, 2024

Summary

This makes sure that we won't add a class that's already present in the union type for pivots. This can happen when multiple relations use the same Pivot class.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Misc. change (internal, infrastructure, maintenance, etc.)

Checklist

  • Existing tests have been adapted and/or new tests have been added
  • Add a CHANGELOG.md entry
  • Update the README.md
  • Code style has been fixed via composer fix-style

@pataar
Copy link
Contributor Author

pataar commented Oct 28, 2024

@barryvdh I saw that you're planning to remove the CHANGELOG.md. I ignored it in this PR to avoid any conflicts.

@pataar pataar force-pushed the avoid_duplicate_class_names branch 2 times, most recently from 62b502d to 8806fe5 Compare October 28, 2024 20:13
@pataar pataar force-pushed the avoid_duplicate_class_names branch from b756dd7 to 9e17811 Compare October 28, 2024 20:14
@barryvdh barryvdh merged commit 07e3bd8 into barryvdh:master Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants