Skip to content

Conversation

@eldair
Copy link
Contributor

@eldair eldair commented Feb 28, 2025

Summary

Fixed wrong php doc being generated for withTrashed method when SoftDeletes trait is used in a model.

Previously this doc looked like this (missing parameter):
* @method static \Illuminate\Database\Eloquent\Builder<static>|Simple withTrashed()
When it should look like this (taken from the trait itself)
* @method static \Illuminate\Database\Eloquent\Builder<static>|Simple withTrashed(bool $withTrashed = true)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Misc. change (internal, infrastructure, maintenance, etc.)

Checklist

  • Existing tests have been adapted and/or new tests have been added
  • Update the README.md
  • Code style has been fixed via composer fix-style

@eldair
Copy link
Contributor Author

eldair commented May 29, 2025

@barryvdh can you take a look please?

@barryvdh barryvdh merged commit cff244b into barryvdh:master Jul 17, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants