Skip to content

Conversation

@erikn69
Copy link
Contributor

@erikn69 erikn69 commented May 14, 2025

Summary

There is no standard for "macroable", it should only work with the native Laravel one. (Alternative to #1706)

Example:

Even the author agrees that the macros for other "macroable" traits could not be obtained (#1629 (comment)).

Hey @barryvdh Thanks for your help and the merge. FYI, it's still not working with Filament, as I just saw they don't use the same macroable code as Laravel: Laravel:
Screenshot 2025-01-16 at 17 22 08

Filament:
Screenshot 2025-01-16 at 17 21 59

Hence, it's obviously not compatible with this package Alias::getMacroFunction function... 😞
Not sure whether you'd like to provide a special treatment for them?

@barryvdh that PR was merged causing many problems, please revert it 🙏
I also think I can improve some things here, but I depend on this

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Misc. change (internal, infrastructure, maintenance, etc.)

Checklist

  • Existing tests have been adapted and/or new tests have been added
  • Update the README.md
  • Code style has been fixed via composer fix-style

@barryvdh barryvdh merged commit c775aec into barryvdh:master May 14, 2025
32 checks passed
@erikn69 erikn69 deleted the fix_macros branch May 14, 2025 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants