Revert "go_grpc_compiler: default to go_grpc_v2 (#2071)" #2171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e425d46. Moving to @io_bazel_rules_go//proto:go_grpc_v2 is not a drop-in replacement and fails if the proto library has both messages and services defined. Fixes bazel-contrib#2170
Contributor
|
I suggest not going back to the deprecated solution. Instead, let's try getting #2085 merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit e425d46.
Moving to @io_bazel_rules_go//proto:go_grpc_v2 is not a drop-in replacement and fails if the proto library has both messages and services defined.
Fixes #2170
What type of PR is this?
What package or component does this PR mostly affect?
gRPC and go_proto_compiler
What does this PR do? Why is it needed?
Moving to @io_bazel_rules_go//proto:go_grpc_v2 is not a drop-in replacement and fails if the proto library has both messages and services defined. This reverts commit e425d46.
Which issues(s) does this PR fix?
Fixes #2071
Other notes for review